feat: check paths completed for all retrieval types #386
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## rvagg/byte-range-proper #386 +/- ##
===========================================================
+ Coverage 76.93% 76.98% +0.05%
===========================================================
Files 87 87
Lines 6611 6608 -3
===========================================================
+ Hits 5086 5087 +1
+ Misses 1255 1254 -1
+ Partials 270 267 -3
|
|
Changed to Draft while we consider strategy - maybe via the daemon you don't need/want to signal an error as you technically fulfilled the request and it's up to a upstream party to decide that this is an error. On the CLI we probably want to let the user know. Also, maybe the error shouldn't be per retriever, perhaps it ought to be validated after the retrieval occurs--in which case maybe the |
rvagg
force-pushed
the
rvagg/byte-range-proper
branch
from
ad5766c
to
c40fe59
Compare
rvagg
force-pushed
the
rvagg/path-too-far-fail
branch
from
79b6f80
to
88ccb73
Compare
rvagg
force-pushed
the
rvagg/byte-range-proper
branch
2 times, most recently
from
ba2f0b7
to
08d6372
Compare
|
some of this will be included in #404, we can opt for checking |
Depends on filecoin-project/go-data-transfer#378 for the graphsync part of this. Also includes a little bit of cleanup that makes the diff noisier.
Because traversals don't strictly need to run to any pre-defined completion, we have to check it ourselves - we watch the
LastPathin the traversal progress and then check whether it at least fulfils our initial path request.